Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update associate-public-ip-address-vm.md #125454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update associate-public-ip-address-vm.md #125454

wants to merge 1 commit into from

Conversation

conradj3
Copy link
Contributor

@conradj3 conradj3 commented Jan 3, 2025

  • Change verbiage away from 'security groups' to its proper noun for Azure object Network Security Group
  • Add Network Security Group reference for blade menu Inbound Security Rules to adjust ports/protocols required to access Azure Public Ip

@conradj3
Update associate-public-ip-address-vm.md
beb20e1 
Change verbiage away from 'security groups' to its proper noun Network Security Groups and add Inbound Security Rules reference.
@prmerger-automator PRMerger Automator
Copy link
Contributor

@conradj3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit beb20e1:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-network/ip-services/associate-public-ip-address-vm.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jan 3, 2025

@mbender-ms

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jan 3, 2025
mbender-ms
mbender-ms suggested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@mbender-ms mbender-ms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions @conradj3! The changes make the language more precise and are approved.

Per our style guidance, only capitalize services/features when specifically speaking to the product. When referring to an instance of a product/feature, use lower case. In all the instances you've updated, please use lower case for network security group and inbound security rules.

Please make the necessary changes to your PR for case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbender-ms mbender-ms mbender-ms requested changes

Assignees

@mbender-ms mbender-ms

Labels
aq-pr-triaged tracking label for the PR review team azure-virtual-network/svc Change sent to author do-not-merge ip-services/subsvc qualifies-for-auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conradj3 @Court72 @mbender-ms